feat: Check-in polymorph generated code #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
josecorella
approved these changes
Dec 17, 2024
...untimes/go/ImplementationFromDafny-go/awscryptographyprimitivessmithygenerated/api_client.go
Show resolved
Hide resolved
...untimes/go/ImplementationFromDafny-go/awscryptographyprimitivessmithygeneratedtypes/types.go
Show resolved
Hide resolved
...mitives/runtimes/go/TestsFromDafny-go/awscryptographyprimitivessmithygeneratedtypes/types.go
Show resolved
Hide resolved
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes: Formatting for
externsAddition:
make polymoprh_gogenerated code -shim.goand*smithygenerated.go. Since these files are huge, has no business logic, and is Tested as part ofsmithy-dafnyandTestVectors, it should be OK to do a spot check. But a full review is always welcome.CI: CI will be added as part of
MPLcommit, otherwise it'd fail today since we runpolymorph_codegenfor all packages and not individual ones.Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.