Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repolymorph to get dotnet constraint checking #281

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner April 12, 2024 21:24
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajewellamz ajewellamz merged commit 04102d7 into main Apr 15, 2024
54 checks passed
@ajewellamz ajewellamz deleted the ajewell/repolymorph branch April 15, 2024 18:01
@texastony
Copy link
Contributor

@robin-aws Do you know why the properties files were added in this PR?
I hope to remove them in subsequent PR.

@robin-aws
Copy link
Contributor

Yes please do remove them, we shouldn't have them committed since these repos use a top-level project.properties instead.

This is a side-effect of the consolidation into a single shared makefile: the smithy-dafny TestModels need the per-library copy emitted in order to build. I'll see if there's a quick patch to smithy-dafny to make that happen ONLY in the TestModels scope.

kessplas pushed a commit that referenced this pull request Apr 23, 2024
# [1.3.0](v1.2.0...v1.3.0) (2024-04-23)

### Bug Fixes

* **dafny:** Local Service Constructors MUST return concrete ([64f72c1](64f72c1))
* dir name in java mpl release process ([#162](#162)) ([d92c06a](d92c06a))
* Re-Polymorph w/ Smithy-Dafny@3378be16 & fix Java Testing ([#190](#190)) ([58d74f6](58d74f6))

### Features

* enable KMS MRK Keys in KeyStore ([#285](#285)) ([d924395](d924395))
* remove quantifier-syntax ([#218](#218)) ([76ab6ef](76ab6ef))
* repolymorph to get dotnet constraint checking ([#281](#281)) ([04102d7](04102d7))
lucasmcdonald3 pushed a commit that referenced this pull request Apr 24, 2024
# [1.3.0](v1.2.0...v1.3.0) (2024-04-24)

### Bug Fixes

* **dafny:** Local Service Constructors MUST return concrete ([64f72c1](64f72c1))
* dir name in java mpl release process ([#162](#162)) ([d92c06a](d92c06a))
* **KeyStore:** JavaDocs for KMS Configuration ([#293](#293)) ([63ffff5](63ffff5))
* Re-Polymorph w/ Smithy-Dafny@3378be16 & fix Java Testing ([#190](#190)) ([58d74f6](58d74f6))

### Features

* enable KMS MRK Keys in KeyStore ([#285](#285)) ([d924395](d924395))
* remove quantifier-syntax ([#218](#218)) ([76ab6ef](76ab6ef))
* repolymorph to get dotnet constraint checking ([#281](#281)) ([04102d7](04102d7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants