Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_waiter to use new interface #954

Merged
merged 2 commits into from
Oct 18, 2014
Merged

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Oct 17, 2014

I've added tests for this function (was previously untested)
to ensure we don't regress on this again in the future.

Also manually verified.

  1. Launched a cluster
  2. Ran aws emr ssh --cluster-id <myid> --key-pair-file <foo> --debug 2>&1 | grep waiter
  3. Verified we were calling the waiter properly:
$ aws emr ssh --cluster-id <cluster-id> --key-pair-file <keypair-file> --debug 2>&1 | grep waiter
2014-10-17 13:57:13,069 - MainThread - botocore.waiter - DEBUG - Waiter ClusterRunning waiting.
2014-10-17 13:57:13,170 - MainThread - botocore.waiter - DEBUG - No acceptor state reached for waiter ClusterRunning, attempt 0/60, sleeping for: 30
2014-10-17 13:57:43,227 - MainThread - botocore.waiter - DEBUG - No acceptor state reached for waiter ClusterRunning, attempt 1/60, sleeping for: 30
2014-10-17 13:58:13,277 - MainThread - botocore.waiter - DEBUG - No acceptor state reached for waiter ClusterRunning, attempt 2/60, sleeping for: 30
...

cc @kyleknap @danielgtaylor

I've added tests for this function (was previously untested)
to ensure we don't regress on this again in the future.
@kyleknap
Copy link
Contributor

LGTM 🚢

@jamesls jamesls merged commit 95216bb into aws:develop Oct 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants