Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Update checksum calculation and validation for vendored botocore #9091

Open
wants to merge 5 commits into
base: s3-request-response-checksum-calculation
Choose a base branch
from

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Nov 20, 2024

Issue #, if available:

Description of changes:

  • Remove MD5 checksums and make CRC32 the default checksum algorithm.
  • When the request_checksum_calculation config is set to when_supported (default value), a checksum will be conditionally generated (detailed in source PR)
  • When the request_checksum_calculation config is set to when_required, a checksum will be generated conditionally (detailed in source PR):
  • Deprecates existing customizations for MD5 checksums.
  • A value set for requestValidationModeMember config by the user will be used by the SDK.
  • If the requestValidationModeMember value is not set by the user, the requestValidationModeMember will conditionally be set to ENABLED (detailed in source PR)

Description of tests:

  • Ran and passed all added botocore tests included in this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant