Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding scheduler cli-examples #8983

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

onkabes
Copy link

@onkabes onkabes commented Oct 17, 2024

Issue #, if available:

Description of changes:

Adding example CLI commands for AWS EventBridge Scheduler: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/scheduler/index.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall self-assigned this Oct 21, 2024
@elysahall elysahall added the documentation This is a problem with documentation. label Oct 21, 2024
@elysahall elysahall self-requested a review October 21, 2024 16:23
@elysahall elysahall added the pr:work-in-progress This PR is a draft and needs further work. label Oct 30, 2024
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onkabes,

Thank you for your submission. Please complete the requested Style Guide fixes for your examples. Note that the comment to change your tab indents to 4 spaces for each indent needs to be applied to all your files.

Thanks.

awscli/examples/scheduler/create-schedule-group.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/create-schedule.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/create-schedule-group.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/create-schedule.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/delete-schedule-group.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/list-tags-for-resource.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/tag-resource.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/tag-resource.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/untag-resource.rst Outdated Show resolved Hide resolved
awscli/examples/scheduler/untag-resource.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkabes A couple more fixes and we should be good for dev review.

@@ -0,0 +1,17 @@
**To retrieves the specified schedule group**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To retrieves the specified schedule group**
**To retrieves the specified schedule group**

This is missing a line break and therefore doesn't render correctly.

aws scheduler create-schedule-group \
--name DailySNSFunction

Ouput ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ouput ::
Output::

This line needs to be fixed in all your examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants