Cast to correct types for list-structure(list-scalar, scalar) #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the shorthand JSON parsing to make sure a list of structures
are cast to the correct types based on the service model. Previously they
would all be set as strings, for example with EMR:
```
$ aws emr modify-instance-groups --instance-groups InstanceGroupId=foo,InstanceCount=3
Invalid value ('3') for param element of list:InstanceGroups of type list
```
In the above, the `3` was parsed as a string rather than an integer. This
update uses `unpack_scalar_cli_arg` to fix the issue by casting to the proper
types.
| arg_types = {} | ||
| for arg in param.members.members: | ||
| # Arg name -> arg object lookup | ||
| args[arg.name] = arg | ||
| # Arg name -> arg type lookup | ||
| arg_types[arg.name] = arg.type |
There was a problem hiding this comment.
Do we need both args and arg_types. If we're storing the whole object could we just use args[name].type instead?
There was a problem hiding this comment.
Good point - I'll update it.
|
|
danielgtaylor
added a commit
that referenced
this pull request
May 14, 2014
Cast to correct types for list-structure(list-scalar, scalar). Fixes #776.
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
This command currently prints version information in JSON format. In future we will expand this to print everything from versions of dependencies, list of commands available, capabilities exposed by the commands, etc. Hopefully eventually this will provide a nice list of machine readable instructions for other tools to integrate with SAM CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the shorthand JSON parsing to make sure a list of structures
are cast to the correct types based on the service model. Previously they
would all be set as strings, for example with EMR:
In the above, the
3was parsed as a string rather than an integer. Thisupdate uses
unpack_scalar_cli_argto fix the issue by casting to the propertypes.
Please review @jamesls.