Register disable_signing first to ensure proper usage #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
approved these changes
Oct 24, 2022
jonemo
approved these changes
Oct 24, 2022
nateprewitt
force-pushed
the
this_but_first
branch
from
10c3d20 to
68db227
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7358 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 205 205
Lines 16452 16481 +29
==========================================
Hits 14 14
- Misses 16438 16467 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nateprewitt
force-pushed
the
this_but_first
branch
from
68db227 to
b276e6a
Compare
jonemo
approved these changes
Oct 24, 2022
aws-sdk-python-automation
added a commit
that referenced
this pull request
Oct 25, 2022
* release-1.26.0: Bumping version to 1.26.0 Add changelog entries from botocore Update changelog based on model updates Update signing handler and tests for MRAP (#7358)
ConnorKirk
pushed a commit
to ConnorKirk/aws-cli
that referenced
this pull request
Oct 28, 2022
godd9170
pushed a commit
to godd9170/aws-cli
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure we register the
disable_signingevent handler first when the flag--no-sign-requestglobal arg is passed. This is to avoid race conditions with other handlers for a response when choosing an appropriate signer.