Update s3 high level commands to honor "--no-verify-ssl" #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two included are: * parsing the jmespath --query arg * resolving the verify ssl argument (including env var lookup) This is code that otherwise every plugin would have to call, so it makes sense to do this as part of the parsing process. This is just like argparse's "type" arg, except plugins can more easily hook into this.
|
LGTM. 🚢 it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696.
This fix is a little bit larger than probably expected because it solves the problem in the general case. The top level global args are now resolved/subjected to additional processing before calling any command/subcommands. This means that additional high level commands can just call
get_endpointwith the parsed_args and they will get the verify ssl arg properly resolved already.Also had to update the s3 commands to actually use the
verify_sslargument. Tests added, and also manually verified: