Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase docutils upper bound to <0.21 #6011

Closed
wants to merge 2 commits into from
Closed

Increase docutils upper bound to <0.21 #6011

wants to merge 2 commits into from

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Mar 11, 2021 •
edited
Loading

Issue #, if available: Closes #4837

Description of changes: Analogous to #4420. I believe this should be safe now that aws-cli has dropped support for python 3.4? (ref https://docutils.sourceforge.io/HISTORY.html#release-0-16)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily added dependencies This issue is a problem in a dependency. pr:needs-review This PR needs a review from a Member. labels Mar 11, 2021
@kdaily
Copy link
Member

kdaily commented Mar 11, 2021

Thanks @tkelman. It looks like 0.17 is still in pre-release. We would need to wait for a final release and then test it out internally.

@tkelman
Copy link
Contributor Author

tkelman commented Mar 11, 2021

Correct @kdaily, but I'm keeping it a strict upper bound here, and 0.16 was released Jan 12, 2020. Would you rather bump the strict upper bound by 2 versions later, or do it in two changes?

@tkelman tkelman force-pushed the bump-docutils branch 2 times, most recently from 7385db2 to 748907b Compare March 12, 2021 22:01
@tkelman tkelman changed the title Increase docutils upper bound to 0.17 Increase docutils upper bound to <0.17 Mar 13, 2021
@tkelman tkelman force-pushed the bump-docutils branch 8 times, most recently from 1d60485 to e55db99 Compare March 19, 2021 20:04
@tkelman
Copy link
Contributor Author

tkelman commented Mar 21, 2021 •
edited
Loading

Would you rather bump the strict upper bound by 2 versions later, or do it in two changes?

And if it's the latter, does the first change (the current version of this PR) need to wait until the next awscli minor release?

I'll assume by a lack of response that the answer is yes? docutils 0.17 was released April 3rd, updated.

@tkelman tkelman force-pushed the bump-docutils branch 5 times, most recently from 61524c2 to 28b0d64 Compare March 29, 2021 20:15
@tkelman tkelman force-pushed the bump-docutils branch 5 times, most recently from 5a06f89 to 6f15c60 Compare April 5, 2021 20:50
@tkelman tkelman force-pushed the bump-docutils branch 2 times, most recently from 5ebe05a to 2c5598d Compare April 7, 2021 14:29
@tkelman tkelman changed the title Increase docutils upper bound to <0.17 Increase docutils upper bound to <0.18 Apr 7, 2021
@stancel
Copy link

stancel commented Oct 23, 2021

Hi @kdaily, it looks like docutils current version of 0.17.1 is a full release. Any chance we could get this change merged into awscli?

@tkelman tkelman force-pushed the bump-docutils branch 2 times, most recently from 8a1a956 to 92c2550 Compare October 24, 2021 22:22
@tkelman
Copy link
Contributor Author

tkelman commented Oct 24, 2021 •
edited
Loading

docutils 0.18 is also in pre-release right now has been released as well

@tkelman tkelman changed the title Increase docutils upper bound to <0.18 Increase docutils upper bound to <0.19 Oct 26, 2021
@kdaily kdaily mentioned this pull request Jan 3, 2022
Open
@justindho justindho added community ready-for-review needs-rebase and removed pr:needs-review This PR needs a review from a Member. labels May 25, 2022
@tkelman tkelman force-pushed the bump-docutils branch 2 times, most recently from aa601ae to 2b45f4a Compare July 12, 2022 20:36
@tkelman tkelman changed the title Increase docutils upper bound to <0.19 Increase docutils upper bound to <0.20 Jul 12, 2022
@tkelman tkelman mentioned this pull request Jul 27, 2022
Closed
@asford
Copy link

asford commented Oct 26, 2022

@nateprewitt @kdaily (from #5943 and #4837)

Is there anything blocking this dep update?

@RDCH106
Copy link

RDCH106 commented Nov 18, 2022

@nateprewitt @kdaily (from #5943 and #4837)

Is there anything blocking this dep update?

I think there is nothing pending that blocks it.

A dependency that is limited above to a version that was released two years ago is still a problem... 😔

It is also another recent PR with the same change #7384

@stancel
Copy link

stancel commented Nov 18, 2022

+1

@tkelman
Copy link
Contributor Author

tkelman commented Nov 18, 2022

Worth noting that #7384 has the advantage that it was auto-generated by dependabot, but that PR is against the v2 branch so it would separately need to be backported to awscli v1.

@tkelman tkelman changed the title Increase docutils upper bound to <0.20 Increase docutils upper bound to <0.21 Jul 17, 2023
@tim-finnigan
Copy link
Contributor

Closing in favor of newer dependabot PRs.

@tkelman
Copy link
Contributor Author

tkelman commented Mar 26, 2024

It looks to me like those dependabot PR's that are against v1 (develop) may need some manual tweaking to also update setup.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community dependencies This issue is a problem in a dependency. needs-rebase ready-for-review
Projects
AWS CLI Community Contributions
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New docutils 0.16 release goes past pin in awscli and botocore
8 participants
@tkelman @kdaily @codecov-commenter @stancel @asford @RDCH106 @tim-finnigan @justindho