Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get-token implementation for EKS #4141

Merged
merged 2 commits into from
May 10, 2019
Merged

Adding get-token implementation for EKS #4141

merged 2 commits into from
May 10, 2019

Conversation

sgundapu
Copy link
Contributor

@sgundapu sgundapu commented May 9, 2019

Issue #, if available:

Description of changes:
Adding get-token implementation for EKS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@joguSD joguSD self-assigned this May 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #4141 into develop will decrease coverage by 0.22%.
The diff coverage is 73.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4141      +/-   ##
===========================================
- Coverage    94.46%   94.24%   -0.23%     
===========================================
  Files          187      188       +1     
  Lines        14121    14170      +49     
===========================================
+ Hits         13340    13355      +15     
- Misses         781      815      +34
Impacted Files Coverage Δ
awscli/customizations/eks/update_kubeconfig.py 97.91% <ø> (-0.24%) ⬇️
awscli/customizations/eks/__init__.py 100% <100%> (ø) ⬆️
awscli/customizations/eks/get_token.py 72.88% <72.88%> (ø)
awscli/compat.py 78.12% <0%> (-9.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbac6ba...2f4b74e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #4141 into develop will decrease coverage by 0.02%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4141      +/-   ##
===========================================
- Coverage    94.46%   94.43%   -0.03%     
===========================================
  Files          187      188       +1     
  Lines        14121    14136      +15     
===========================================
+ Hits         13340    13350      +10     
- Misses         781      786       +5
Impacted Files Coverage Δ
awscli/customizations/eks/update_kubeconfig.py 97.91% <ø> (-0.24%) ⬇️
awscli/customizations/eks/__init__.py 100% <100%> (ø) ⬆️
awscli/compat.py 91.77% <100%> (+4.27%) ⬆️
awscli/customizations/eks/get_token.py 72.88% <72.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbac6ba...8fb4874. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants