Merge bools #285
Merged
Merge bools #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also unify the public attrs that were added in CLIArgs but not added to the base class. In general, all public interfaces need to be defined in the base CLI class to make it clear what subclasses need to implement.
| def py_name(self): | ||
| return self._name.replace('-', '_') | ||
|
|
||
| @property | ||
| def name(self): | ||
| return self._name | ||
| def choices(self): |
There was a problem hiding this comment.
As someone on the relative outside, it'd be nice to have a docstring here describing what this was for. The other properties are relatively obvious, but this one is a mystery.
There was a problem hiding this comment.
Will update. It essentially maps to the choices arg in argparse.ArgumentParser which is just a list of valid choice the value of the arg can be.
|
LGTM. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
Use Inspector instead of Legacy Debugger
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226.
Docs now look like how they use to:
This depends on the corresponding bcdoc changes here: boto/bcdoc#17
If you want to test this locally you'll need to pull in the above change. Note that this will also cause the travis ci builds to fail until boto/bcdoc#17 is merged.