Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cloudformation deploy command polling delay #2686

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Reduce cloudformation deploy command polling delay #2686

merged 2 commits into from
Jul 6, 2017

Conversation

sanathkr
Copy link
Contributor

Customers have asked for a faster deployment time.
See aws/serverless-application-model#125. This fix should
at least make the command complete as soon as cloudformation completes.

Customers have asked for a faster deployment time.
See aws/serverless-application-model#125. This fix should
at least make the command complete as soon as cloudformation completes.
@sanathkr
Copy link
Contributor Author

@JordonPhillips can I get a review on this? It might be a small change but could give good wins.

Copy link
Member

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll merge this later today

@JordonPhillips JordonPhillips merged commit 2509b8f into aws:develop Jul 6, 2017
@codecov-io
Copy link

Codecov Report

Merging #2686 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2686      +/-   ##
===========================================
+ Coverage    95.56%   95.56%   +<.01%     
===========================================
  Files          151      151              
  Lines        11800    11801       +1     
===========================================
+ Hits         11277    11278       +1     
  Misses         523      523
Impacted Files Coverage Δ
awscli/customizations/cloudformation/deployer.py 96.05% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c67913...0fa3cec. Read the comment docs.

@michaellieberherr
Copy link

@sanathkr @JordonPhillips : This fix introduces an other issue, you run into "WaiterError: Waiter StackCreateComplete failed: Max attempts exceeded" if you have a template with for instance CloudFront resources (takes 10min+). I think the fix would be to increase the max retry attempts waiter.config.max_attempts = 720 too, so that the max wait time will still be 60 mins in accordance to https://github.com/boto/botocore/blob/develop/botocore/data/cloudformation/2010-05-15/waiters-2.json#L24

@sanathkr
Copy link
Contributor Author

sanathkr commented Aug 4, 2017

@michaellieberherrr good point. We should change max attempts as well. Can you send a PR for it?

@Seblat5ch
Copy link

I have submitted the pull request before seeing this discussion. However rather than increasing the max attempts we could just tweak the polling interval. #2761

@sanathkr
Copy link
Contributor Author

Nah, I would rather increase the max attempts. Could you make that change, instead? It optimizes for both long running tasks and quick tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants