-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce cloudformation deploy
command polling delay
#2686
Conversation
Customers have asked for a faster deployment time. See aws/serverless-application-model#125. This fix should at least make the command complete as soon as cloudformation completes.
@JordonPhillips can I get a review on this? It might be a small change but could give good wins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll merge this later today
Codecov Report
@@ Coverage Diff @@
## develop #2686 +/- ##
===========================================
+ Coverage 95.56% 95.56% +<.01%
===========================================
Files 151 151
Lines 11800 11801 +1
===========================================
+ Hits 11277 11278 +1
Misses 523 523
Continue to review full report at Codecov.
|
@sanathkr @JordonPhillips : This fix introduces an other issue, you run into "WaiterError: Waiter StackCreateComplete failed: Max attempts exceeded" if you have a template with for instance CloudFront resources (takes 10min+). I think the fix would be to increase the max retry attempts |
@michaellieberherrr good point. We should change max attempts as well. Can you send a PR for it? |
I have submitted the pull request before seeing this discussion. However rather than increasing the max attempts we could just tweak the polling interval. #2761 |
Nah, I would rather increase the max attempts. Could you make that change, instead? It optimizes for both long running tasks and quick tasks |
Customers have asked for a faster deployment time.
See aws/serverless-application-model#125. This fix should
at least make the command complete as soon as cloudformation completes.