Print failure when creating local file fails #1646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phss
changed the title
|
Looks good, I'm just going to add a quick integration test before merging. Thanks for the PR. |
|
Merged in your PR and added an additional integ test. Tracking over in #1648 . |
|
Thanks for merging @jamesls. And apologies as I completely forgot about permission issues on Windows. |
thoward-godaddy
pushed a commit
to thoward-godaddy/aws-cli
that referenced
this pull request
Feb 12, 2022
To support debugging for Nodejs10.x and Nodejs12.x, SAM CLI overrides the entrypoint to the container. In newer runtimes (that are based on the provided runtime), we overrided the bootstrap file which can have side-effects. In the case of Nodejs, the bootstrap file adds the NODE_PATH env var. Since we override this, NODE_PATH does not get setup on the system and causes modules to not load (in some cases, aws#1246). With aws#1634 (Java11 Debug support), we added a capability to attach Env Vars into the container for debug mode invokes. We will use this to apply the NODE_PATH onto the container for debug. I attempted to move all the args we pass into NODE_OPTIONS, which would make Nodejs work like Java11 for debug. That is, allow us not to override the entrypoint and still be able to apply the needed flags to the interpreted. Unfortunately, NODE_OPTIONS restricts values that can be passed in, which includes `--nolazy`. This flag is used to tell Nodejs to parse all JavaScript files first instead of on first access. This ensures that breakpoints to not "jump" to a different location in the file. It could be worth exploring whether `--nolazy` is strictly required but for now leaving as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1645. May fix #1069 and #1442.
This only applies when downloading large files. See issue #1645 for more details.