Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paging help through "more" command on windows #1195

Merged
merged 2 commits into from
Mar 4, 2015

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Mar 3, 2015

This is an alternate to #1168 except it refactors the existing internals to support paging through "more" on windows rather than using pydoc. I also confirmed that this works on powershell as well as cmd.

The existing PR had failing travis CI builds and was overwriting the PAGER env var.

Closes #1168.

cc @kyleknap @danielgtaylor

jamesls added 2 commits March 2, 2015 15:10
This refactors some of the internals to support paging
to "more" on windows.  This is available both in powershell
and in cmd.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.38% when pulling 1b8b091 on jamesls:page-windows into 0881cb0 on aws:develop.

@danielgtaylor
Copy link
Contributor

LGTM 🚢-it.

@kyleknap
Copy link
Contributor

kyleknap commented Mar 3, 2015

Same 🚢

@jamesls jamesls merged commit 1b8b091 into aws:develop Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants