Add customization to alter scalar parsing behavior #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes aws#1001. This also fixes a regression we had when displaying binary content. As mentioned on the github issue, we were previously always showing binary content as base64 encoded. This PR adds back this behavior. In addition, this also gives us a hook into changing the timestamp parsing so we can later add a config option to unify the way timestamps are displayed. Also fixes aws#970, and closes aws#1005. I've also added an integration test for aws#1001 to ensure we are in fact displaying a response that can be printed to stdout.
|
LGTM 🚢-it! Would be nice to see the tests pass and the updated coverage once the Botocore change goes in. |
| # language governing permissions and limitations under the License. | ||
| """Change the scalar response parsing behavior for the AWS CLI. | ||
|
|
||
| The underlying library used by botoc |
|
Looks good as well. Just found that one typo. 🚢 |
|
boto/botocore#386 has been merged and I've expanded the module docstring for scalarparse. I'll wait on the travis build to ensure that all tests are passing before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1001. This also fixes a regression we had
when displaying binary content (this comment has more info).
As mentioned on the github issue, we were previously always
showing binary content as base64 encoded. This PR adds back
this behavior.
In addition, this also gives us a hook into changing the
timestamp parsing so we can later add a config option to
unify the way timestamps are displayed.
Also fixes #970, and closes #1005.
I've also added an integration test for #1001 to ensure
we are in fact displaying a response that can be printed to
stdout.
Depends on boto/botocore#386
cc @kyleknap @danielgtaylor