Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSE with Customer Key Support to S3 Sync #1377

Closed
poldon opened this issue Jun 9, 2015 · 1 comment
Closed

Add SSE with Customer Key Support to S3 Sync #1377

poldon opened this issue Jun 9, 2015 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@poldon
Copy link

poldon commented Jun 9, 2015

Please add the ability to use SSE with a customer key to the aws s3 command, especially sync. I see that s3api has support for customer keys, just not the high-level s3 commands. Thanks!
@kyleknap
Copy link
Contributor

Marking as feature request.

@kyleknap kyleknap added the feature-request A feature should be added or improved. label Jun 11, 2015
@0xkag 0xkag mentioned this issue Sep 2, 2015
Closed
@kyleknap kyleknap mentioned this issue Nov 5, 2015
Merged
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
@brianz
Add to PipelineExecutionRolePermissions to allow stack deletion (aws#…
9a3aee3 
…3213)

* Revert "release: 0.20.0"

* chore: Update version to 0.20.1

* Revert "Revert "release: 0.20.0"" (aws#1377)

This reverts commit 20904315bea1db89362b59550e03ab8460a7d73d.

* Add to PipelineExecutionRolePermissions to allow stack deletion

Why
---

The `PipelineExecutionRole` is assumed by the `PipelineUser` when deploying CI/CD pipelines.
This role doesn't have permission to delete stacks via `sam delete`. This means that any stacks
created need to be deleted manually. In order to support automated stack deletions for feature
branches, this role needs a few extra permissions.

This change is needed to support the this PR in the sam pipeline
templates:

aws/aws-sam-cli-pipeline-init-templates#42

How
---

- Add three additional IAM permissions which allow the `sam delete`
command to work as expected in `PipelineExecutionRolePermissions`.

Next Steps
----------

- After this is merged, [this PR in the Pipeline templates for GitHub
Actions](aws/aws-sam-cli-pipeline-init-templates#42)
can be merged.

* Add BatchDeleteImage to PipelineExecutionRolePermissions

Based on PR feedback, allow for this role to delete a list of ImageIds
by adding `ecr:BatchDeleteImage` to the Pipeline role.
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this issue Feb 12, 2022
@prowe-athene @sanathkr
@jfuss @sriram-mv @awood45 @c2tarun @aws-sam-cli-bot @aahung
Add CFN stack sets to supported resources (aws#3249)
1c98e68 
* Revert "release: 0.20.0"

* chore: Update version to 0.20.1

* Revert "Revert "release: 0.20.0"" (aws#1377)

This reverts commit 20904315bea1db89362b59550e03ab8460a7d73d.

* Add CFN stack sets to supported resources

Adds the ability to upload CloudFormation StackSet `TemplateURL` files

Co-authored-by: Sanath Kumar Ramesh <[email protected]>
Co-authored-by: Jacob Fuss <[email protected]>
Co-authored-by: Sriram Madapusi Vasudevan <[email protected]>
Co-authored-by: Alex Wood <[email protected]>
Co-authored-by: Tarun <[email protected]>
Co-authored-by: Sriram Madapusi Vasudevan <[email protected]>
Co-authored-by: aws-sam-cli-bot <[email protected]>
Co-authored-by: _sam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyleknap @poldon