Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws kinesis put-record no longer encodes --data parameter #1033

Closed
garnaat opened this issue Nov 29, 2014 · 3 comments
Closed

aws kinesis put-record no longer encodes --data parameter #1033

garnaat opened this issue Nov 29, 2014 · 3 comments
Assignees
@jamesls
Labels
bug This issue is a bug.

Comments

@garnaat
Copy link
Contributor

garnaat commented Nov 29, 2014

In previous versions you could pass a string as the --data parameter of the put-record command and the data would be automatically encoded as base64 prior to uploading it to Kinesis.

This no longer happens and forcing the user to do the encoding themselves seems like a real nuisance. I think this happened when botocore was switched over to the new models.

See also boto/botocore#385
@garnaat
Copy link
Contributor Author

garnaat commented Nov 29, 2014

Also see http://docs.aws.amazon.com/lambda/latest/dg/walkthrough-kinesis-events-adminuser-configure-kinesis.html#walkthrough-kinesis-final-integration-test-no-iam for a reference to the old behavior which no longer works.

I would try to fix this myself but I'm a bit unclear about how this is handled in the new models.

@jamesls
Copy link
Member

jamesls commented Dec 1, 2014

Taking a look.

@jamesls jamesls added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 1, 2014
jamesls added a commit to jamesls/botocore that referenced this issue Dec 1, 2014
@jamesls
Fix base64 serialization in JSON protocol
88c8727 
This includes adding additional protocol tests for blob serialization.
These were no tests for blobs in the json protocol input tests.

Fixes boto#385, aws/aws-cli#1033
@jamesls jamesls mentioned this issue Dec 1, 2014
Merged
@jamesls jamesls added confirmed bug This issue is a bug. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 2, 2014
@jamesls jamesls self-assigned this Dec 2, 2014
@jamesls
Copy link
Member

jamesls commented Dec 2, 2014

Fixed via boto/botocore#394

@jamesls jamesls closed this as completed Dec 2, 2014
@jamesls jamesls mentioned this issue Dec 6, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesls jamesls

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garnaat @jamesls