-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): control progress output style with --progress=bar|events #9623
Conversation
To improve discoverability of the various options and allow future modes let's use an enumeration:
|
…ed in the future for stack deplyoments
packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update PR description to reflect updated switch name
Added do-not-merge |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@farzad-xgen this flag is under `cdk deploy`.
…On Fri, Sep 4, 2020 at 3:45 PM farzad-xgen ***@***.***> wrote:
$ cdk --help doesn't show this flag.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9623 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHWN5M24DPYNRNWEMX7KDSEFNYXANCNFSM4P4LGYAA>
.
|
Got it, thanks! |
@shivlaks Can you please provide an example on how to set this in Thanks! |
@shivlaks poke Edit: My apologies... figured it out. |
Since the new deployment monitoring has been problematic on environments such as CI,
adding a switch called
progress
to allow users to set their deploy output display preference.Supported values are
bar
andevents
. The default deployment display mode includes theprogress bar.
The workaround of adding
-v
to display the stack event history includes a lot ofundesired output and users have expressed that it includes a lot of noise.
If the key
progress
exists in user settings (~/.cdk.json
) or project settings (cdk.json
),users will not need to specify it on every deploy and can set their desired default once.
closes #8696
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license