chore: jest configs should not rely on source tree layout #8970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way jest configs are currently inheriting from a parent
jest config makes it hard to do an out-of-source build, which we
want for future build improvements.
They used to go `require('../../../tools/cdk-build-tools/...')`,
relying on an exact layout in the source tree.
Given that `cdk-build-tools` is just a dependency of every
package, doing `require('cdk-build-tools/...')` works just as well
and only relies on the standard NPM contract (`node_modules` having
correct symlinks) and not source tree layout.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way jest configs are currently inheriting from a parent
jest config makes it hard to do an out-of-source build, which we
want for future build improvements.
They used to go
require('../../../tools/cdk-build-tools/...'),relying on an exact layout in the source tree.
Given that
cdk-build-toolsis just a dependency of everypackage, doing
require('cdk-build-tools/...')works just as welland only relies on the standard NPM contract (
node_moduleshavingcorrect symlinks) and not source tree layout.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license