Beta bundle #7
Merged
Beta bundle #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade local-npm packages with latest version of JSII (that enables declaration files) - Correct `package.json` files (the `types` field points to the `.d.ts` file now) - Correct `tsconfig.json` files for non-JSII packages, so they enable declaration files. - Add a `.npmignore` file to prevent `npm` from using `.gitignore` instead + Don't pack `.ts` files, but pack `.d.ts` files instead - The change uncovered a bunch of "poor practices", that were fixed as well: + Importing from the package's root (where `package.json` is) cannot work with `.d.ts` files, this was particularly frequent in tests.
- Changed wording, add more references between sections. - Highlighted some details better. - Reorganized discussion about L1s and L2s a bit to make it flow better. - Changes the title of the section that used to be called "using l2s" into "writing CDK apps". - Update formatting. - Get rid of level1, level2 substitutions
…nager `sign.sh` takes a signature type and some files to be signed. This adds a script that loads a secret PGP key from secrets manager and signs arbitrary artifacts with it, creating detached (FILE.sig) signatures.
|
Dry run passes |
RomainMuller
approved these changes
Jun 1, 2018
smguggen
referenced
this pull request
in smguggen/aws-cdk
Aug 24, 2021
# This is the 1st commit message: Add Identity Pool construct # This is the commit message #2: Bug fixes # This is the commit message #3: Bug fixes # This is the commit message #4: Formatting # This is the commit message #5: Add construct methods # This is the commit message #6: Remove flat # This is the commit message #7: Fix issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for #6 - this change will result in
dist/containing a bundle that contains:node_modules- with all jsii and CDK modulesbin- symlink to node_modules/.binrepo/npm- tarballs for all npm modules (CDK + jsii)repo/maven- jars for jsii and CDKdocs- the rendered documentation website