-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-codecommit): New method addToPipelineStage on Repository #616
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,20 +3,17 @@ import cdk = require('@aws-cdk/cdk'); | |
import { RepositoryRef } from './repository'; | ||
|
||
/** | ||
* Construction properties of the {@link PipelineSource CodeCommit source CodePipeline Action}. | ||
* Common properties for creating {@link PipelineSource} - | ||
* either directly, through its constructor, | ||
* or through {@link RepositoryRef#addToPipeline}. | ||
*/ | ||
export interface PipelineSourceProps extends codepipeline.CommonActionProps { | ||
export interface CommonPipelineSourceProps { | ||
/** | ||
* The name of the source's output artifact. | ||
* Output artifacts are used by CodePipeline as inputs into other actions. | ||
*/ | ||
artifactName: string; | ||
|
||
/** | ||
* The CodeCommit repository. | ||
*/ | ||
repository: RepositoryRef; | ||
|
||
/** | ||
* @default 'master' | ||
*/ | ||
|
@@ -31,6 +28,16 @@ export interface PipelineSourceProps extends codepipeline.CommonActionProps { | |
pollForSourceChanges?: boolean; | ||
} | ||
|
||
/** | ||
* Construction properties of the {@link PipelineSource CodeCommit source CodePipeline Action}. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI - the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually just a moved comment, so it doesn't bother me that much... yet ;) |
||
*/ | ||
export interface PipelineSourceProps extends CommonPipelineSourceProps, codepipeline.CommonActionProps { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid multiple inheritance if possible (I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I don't believe it's possible to avoid multiple inheritance here. |
||
/** | ||
* The CodeCommit repository. | ||
*/ | ||
repository: RepositoryRef; | ||
} | ||
|
||
/** | ||
* CodePipeline Source that is provided by an AWS CodeCommit repository. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is artifact name required? Can we get rid of them already (okay if we do that in a subsequent commit). But as far as I understand, they are only needed for referencing in the pipeline model, and in the CDK we can just use an artifact object instead and generate the Artifact name from eg the uniqueId for the Action construct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We have an issue opened for getting rid of (or at least defaulting) them.