refactor(elbv2): introduce ListenerCertificate #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally model certificates in a consistent way, using an `IListenerCertificate` interface (it has to be an interface to be able to maintain backwards compatibility with the erroneously introduced `INetworkListenerCertificateProps` interface) and an implemention of it called `ListenerCertificate`. `ListenerCertificate` can currently be created from an ACM certificate, and in the future should also be creatable from an IAM certificate. Make it the same for ALB and NLBs. Fixes #5330.
rix0rrr
requested review from
RomainMuller,
clareliguori,
eladb,
MrArnoldPalmer,
NetaNir and
nija-at
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ed-at-work
pushed a commit
to ed-at-work/aws-cdk
that referenced
this pull request
Dec 17, 2019
Finally model certificates in a consistent way, using an `IListenerCertificate` interface (it has to be an interface to be able to maintain backwards compatibility with the erroneously introduced `INetworkListenerCertificateProps` interface) and an implemention of it called `ListenerCertificate`. `ListenerCertificate` can currently be created from an ACM certificate, and in the future should also be creatable from an IAM certificate. Make it the same for ALB and NLBs. Fixes aws#5330.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally model certificates in a consistent way, using an
IListenerCertificateinterface (it has to be an interfaceto be able to maintain backwards compatibility with the
erroneously introduced
INetworkListenerCertificatePropsinterface)and an implemention of it called
ListenerCertificate.ListenerCertificatecan currently be created from an ACM certificate,and in the future should also be creatable from an IAM certificate.
Make it the same for ALB and NLBs.
Fixes #5330.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license