Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): refactor notices.ts to not use configuration settings #32558

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

kaizencc
Copy link
Contributor

This is part of a larger effort to make sure that all command-level code does not use configuraiton.settings directly. If it needs a CLI setting, it should be passed in as a parameter to the command-level code. The idea is that the grab bag of configuration.settings stays in cli.ts and only the relevant information is passed along to each command.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner December 17, 2024 23:44
@github-actions github-actions bot added the p2 label Dec 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 17, 2024 23:44
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 17, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 17, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (c1d3130) to head (b38cf58).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32558      +/-   ##
==========================================
+ Coverage   78.85%   78.86%   +0.01%     
==========================================
  Files         108      108              
  Lines        7165     7165              
  Branches     1319     1319              
==========================================
+ Hits         5650     5651       +1     
  Misses       1330     1330              
+ Partials      185      184       -1     
Flag Coverage Δ
suite.unit 78.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.86% <100.00%> (+0.01%) ⬆️

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Dec 18, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Dec 18, 2024

Submitted integ test run and successfully completed.

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 18, 2024 13:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Dec 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b38cf58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 043f9db into main Dec 18, 2024
16 of 17 checks passed
Copy link
Contributor

mergify bot commented Dec 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the conroy/noticesrefactor branch December 18, 2024 13:44
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants