Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codeowners #32194

Merged
merged 5 commits into from
Nov 21, 2024
Merged

chore: codeowners #32194

merged 5 commits into from
Nov 21, 2024

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Nov 19, 2024

Adding a CODEOWNERS file to so that we can require approval from specific teams based on the changed code.

See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-and-branch-protection


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 19, 2024 16:18
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@iliapolo iliapolo changed the title chore: CODEOWNERS chore: codeowners Nov 19, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 19, 2024 16:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (f98023d) to head (94f02d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32194   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181           
Flag Coverage Δ
suite.unit 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (ø)
---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iliapolo iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Nov 19, 2024
@GavinZZ
Copy link
Contributor

GavinZZ commented Nov 21, 2024

@mergify update

Copy link
Contributor

mergify bot commented Nov 21, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 94f02d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@GavinZZ GavinZZ merged commit 326e2c6 into main Nov 21, 2024
15 checks passed
@GavinZZ GavinZZ deleted the epolon/core-codeowners branch November 21, 2024 21:17
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants