feat(cdk): update tsconfig to more modern settings in typescript init templates

[ren-yamanashi]

Issue # (if applicable)

n/A

Reason for this change

I think contents of tsconfig.json are a little outdated and seemed to need update.

Description of changes

The following two changes I made:

1. Removed unnecessary options
2. Updated target and lib options at compilerOptions

1. Removed unnecessary options

Unnecessary options included in the compilerOptions of tsconfig.json.
The unnecessary options are as follows

• noImplicitAny
• strictNullChecks
• noImplicitThis
• alwaysStrict

If strict: true is specified in compilerOptions, these options will also be true, so there is no need to specify them.

see: https://www.typescriptlang.org/tsconfig/#strict

2. Updated target and lib options at compilerOptions

• target
  • I think 'ES2023' is more appropriate for the target option at this point.
• lib
  • Basically, it doesn't seem necessary to specify the same value for the lib option as the target specified in the target option.
  • see: https://www.typescriptlang.org/tsconfig/#lib

Description of how you validated changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mrgrain]

Nice! Going by this https://www.npmjs.com/package/@tsconfig/node-lts we should set the target to ES2022 and lib to include ES2023.

strictPropertyInitialization can also be removed.

Pull request has been modified.

[ren-yamanashi]

@mrgrain

Nice! Going by this https://www.npmjs.com/package/@tsconfig/node-lts we should set the target to ES2022 and lib to include ES2023.

Thank you review! I fixed in the following commit.

strictPropertyInitialization can also be removed.

strictPropertyInitialization is currently set to false, but is it okay to remove it?
Note: If strict: true is set, strictPropertyInitialization will implicitly become true.

If it is better not to remove, I will reset this commit. 6a66600

[mrgrain]

strictPropertyInitialization can also be removed.

strictPropertyInitialization is currently set to false, but is it okay to remove it?
Note: If strict: true is set, strictPropertyInitialization will implicitly become true.

If it is better not to remove, I will reset this commit. 6a66600

Ha nice catch. Let's keep it set to false then for now.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[ren-yamanashi]

Ha nice catch. Let's keep it set to false then for now.

@mrgrain

I have set strictPropertyInitialization back to false, so please check.

Also, there is no README and test, and CI seems to be failing.
Should I address these issues?

The PR that made a similar change to this PR did not seem to have updated the README or test...
#27422

[mrgrain]

Ha nice catch. Let's keep it set to false then for now.

@mrgrain

I have set strictPropertyInitialization back to false, so please check.

Also, there is no README and test, and CI seems to be failing. Should I address these issues?

The PR that made a similar change to this PR did not seem to have updated the README or test... #27422

Great! I can take care of the PR "requirements" ;)

---

Disabled readme and test reqs. This is a change to code that has existing tests. Will run through the cli test pipeline.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f2a66d4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.