Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssm): correctly deduplicate parameter names #3183

Merged
merged 7 commits into from
Jul 3, 2019
Merged

fix(ssm): correctly deduplicate parameter names #3183

merged 7 commits into from
Jul 3, 2019

Commits on Jul 3, 2019

  1. fix(ssm): correctly deduplicate parameter names 

    Parameter names with '/' in them would not be correctly deduplicated,
since the '/' is also used to delimit identifiers in construct paths.

Add protection in core to not allow construct identifiers to be created
with '/' in them, as tryFindChild() would not be able to find it
anymore.

Fixes #3076.
    @rix0rrr
    rix0rrr committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    7cb0922 View commit details
    Browse the repository at this point in the history

  2. Back to implicit sanitizing

    @rix0rrr
    rix0rrr committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    e171763 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into huijbers/slashes-in-construct-name

    Elad Ben-Israel authored Jul 3, 2019
    Configuration menu
    Copy the full SHA
    9496366 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into huijbers/slashes-in-construct-name

    Elad Ben-Israel authored Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d26555d View commit details
    Browse the repository at this point in the history

  5. Use PATH_SEP in regex

    @rix0rrr
    rix0rrr committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    ff4c200 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'huijbers/slashes-in-construct-name' of github.com:awsla… 

    …bs/aws-cdk into huijbers/slashes-in-construct-name
    @rix0rrr
    rix0rrr committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    2ee01b4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into huijbers/slashes-in-construct-name

    Elad Ben-Israel authored Jul 3, 2019
    Configuration menu
    Copy the full SHA
    a055a0e View commit details
    Browse the repository at this point in the history