Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): stateMachine construct doesn't generate a valid policy for default StateMachineRole #31801

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Oct 17, 2024

Issue # (if applicable)

Closes #31714.

Reason for this change

Currently, the step functions runEcsTask() will create an IAM policy. The Resource section is an ARN constructed by CDK with wildcard * appending at the end. However, CDK should Ref the resource directly instead of constructing the ARN, while keeping the revision number.

Description of changes

The same solution as #31615. However this change needs to behind a feature flag because it could be a breaking change.

Description of how you validated changes

Integration test. Also checked the synth template.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Oct 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 17, 2024 23:17
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 17, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xazhao xazhao changed the title fix(stepfunctions-tasks): StateMachine construct doesn't generate a valid policy for default StateMachineRole fix(stepfunctions-tasks): stateMachine construct doesn't generate a valid policy for default StateMachineRole Oct 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 17, 2024 23:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 17, 2024
Copy link
Contributor

mergify bot commented Oct 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@xazhao xazhao added the pr/do-not-merge This PR should not be merged at this time. label Oct 18, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 18, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ef49fb3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@xazhao xazhao removed the pr/do-not-merge This PR should not be merged at this time. label Oct 18, 2024
Copy link
Contributor

mergify bot commented Oct 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit efbbddb into aws:main Oct 18, 2024
15 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_stepfunctions: StateMachine construct doesn't generate a valid policy for default StateMachineRole
4 participants