-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): warning when creating a service with the default minHealthyPercent #31738
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Exemption Request: warning doesn't change synthesized CloudFormation stacks so new integration tests not required. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
1 similar comment
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue
Closes #31705
Reason for this change
CDK overrides the default value of 100% used by CloudFormation's
AWS::ECS::Service
and theCreateService
API. This allows the number of running tasks to drop by up to 50% during deployments and Fargate maintenance etc.This is an unsafe default for services which must support a consistent load e.g. handle web traffic via an ALB.
Description of changes
A warning appears when the default value is implicitly used. CloudFormation's default is overridden in three different places so multiple warnings are added:
BaseService
emits@aws-cdk/aws-ecs:minHealthyPercent
whenminHealthyPercent
isundefined
Ec2Service
emits@aws-cdk/aws-ecs:minHealthyPercentDaemon
whendaemon
istrue
andminHealthyPercent
isundefined
ExternalService
emits@aws-cdk/aws-ecs:minHealthyPercentExternal
whenminHealthyPercent
isundefined
At most one warning appears due to the way the CloudFormation's default is overidden.
README.md
has been updated foraws_ecs
andaws_ecs_patterns
to ensure these examples don't trigger this warning.Description of how you validated changes
Unit tests have been added to ensure the warnings appear are there when they should be and not when they shouldn't.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license