Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): DataProtectionPolicy not displaying properly in console #31725

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cam8001
Copy link

@cam8001 cam8001 commented Oct 11, 2024

Issue # (if applicable)

Closes #26728.

Reason for this change

  • CloudFormation property names should be PascalCased
  • the DataProtectionPolicy construct in aws-logs generates properties with camelCased property names
    • for example, dataIdentifier instead of DataIdentifier
  • Properties with camelCased property names are not recognised by CloudFormation, and so the configuration is not applied.

Description of changes

I have tried to sort this by explicitly specifying the keys in an object in the generation of the CfnLogGroup in log-group.ts.

I'm not sure if I need to go one level deeper to do the same for Statement, but the docs suggest so. It feels a little hacky to do ever deeper explicit specification of keys - if anyone else has any suggestions for a better approach, I'm very open to it!

Description of how you validated changes

Updated tests in loggroup.test.ts

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 11, 2024 02:29
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@cam8001 cam8001 changed the title Fix #26728: DataProtectionPolicy not displaying properly in console fix #26728: DataProtectionPolicy not displaying properly in console Oct 11, 2024
@cam8001 cam8001 changed the title fix #26728: DataProtectionPolicy not displaying properly in console fix #26728: DataProtectionPolicy not displaying properly in console Oct 11, 2024
@cam8001 cam8001 changed the title fix #26728: DataProtectionPolicy not displaying properly in console fix: DataProtectionPolicy not displaying properly in console Oct 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 13, 2024 00:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@cam8001 cam8001 changed the title fix: DataProtectionPolicy not displaying properly in console fix(aws-logs): DataProtectionPolicy not displaying properly in console Oct 13, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe58494
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cam8001 cam8001 changed the title fix(aws-logs): DataProtectionPolicy not displaying properly in console fix(logs): DataProtectionPolicy not displaying properly in console Oct 13, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 13, 2024 01:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(logs) DataProtectionPolicy not displaying properly in the console
2 participants