fix(sqs) KMS-Managed SQS encryption generate valid IAM Policy for gra… #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
I have written an alternate version in #3169, which I reckon is slightly superior (as I noted, there is literally no need for the statement to be emitted in the first place). Nevertheless, thank you for both reporting the issue, and spending the time to attempt a fix (which is good, the above consideration aside!). |
RomainMuller
reviewed
Jul 2, 2019
| @@ -277,7 +277,7 @@ export class Queue extends QueueBase { | |||
| } | |||
|
|
|||
| if (encryption === QueueEncryption.KMS_MANAGED) { | |||
| const masterKey = kms.Key.fromKeyArn(this, 'Key', 'alias/aws/sqs'); | |||
| const masterKey = kms.Key.fromKeyArn(this, 'Key', `arn:aws:kms:${Aws.REGION}:${Aws.ACCOUNT_ID}:alias/aws/sqs`); | |||
There was a problem hiding this comment.
This grant isn't even necessary. The AWS-managed key will allow appropriate usage anyway.
There was a problem hiding this comment.
Makes sense and I've should have noticed this we are dealing with the default key here. :D
Thank you for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(sqs) KMS-Managed SQS encryption generate valid IAM Policy for grantee (#2794)
fixes #2794
Please let me know if this is not the right way to resolve the issue.