Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wildcard in KMS key policy instead of referencing Distribution to avoid circular dependency #31227

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Use wildcard in KMS key policy instead of referencing Distribution to avoid circular dependency #31227

merged 6 commits into from
Aug 28, 2024

Commits on Aug 27, 2024

  1. introduce assembleDomainName option in S3BucketOrigin.withOriginAcces… 

    …sControl plus unit tests
    @samson-keung
    samson-keung committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b08605e View commit details
    Browse the repository at this point in the history

  2. fix using imported bucket with assembleDomainName to true

    @samson-keung
    samson-keung committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f5c308c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. remove assembleDomainName and use wildcard key policy

    @samson-keung
    samson-keung committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    626a8b3 View commit details
    Browse the repository at this point in the history

  2. warn user about wildcard in key policy

    @samson-keung
    samson-keung committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4a8f9c8 View commit details
    Browse the repository at this point in the history

  3. warning wording update

    @samson-keung
    samson-keung committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9449c3c View commit details
    Browse the repository at this point in the history

  4. warning wording update and removed redundant warning

    @samson-keung
    samson-keung committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    dd11f45 View commit details
    Browse the repository at this point in the history