Unit test S3BucketOrigin.withOriginAccessControl with custom props + removed originAccessControlId from OriginBase #31186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test to ensure all props passed to
S3BucketOrigin.withOriginAccessControl
are correctly reflected in the final template.Removed
originAccessControlId
prop fromOriginOptions
as it conflicts with theoriginAccessControl
prop inS3BucketOriginWithOACProps
. See https://github.com/aws/aws-cdk/pull/31150/files#r1727635863 for more context.