-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add aws-sdk
as dev dependency for unit tests and satisfy AwsSdkCall
in unit tests
#29860
Conversation
Signed-off-by: Francis <[email protected]>
AwsSdkCall
in unit testsaws-sdk
dependency for unit tests and satisfy AwsSdkCall
in unit tests
Signed-off-by: Francis <[email protected]>
aws-sdk
dependency for unit tests and satisfy AwsSdkCall
in unit testsaws-sdk
as dev dependency for unit tests and satisfy AwsSdkCall
in unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🚀
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Reason for this change
#29648 introduced a change to the
AwsSdkCall
representation used in the v2 and v3 handler code. Our handler unit tests usesatisfies
to validate that the event object satisfiesAwsSdkCall
. All unit tests and the build still pass, but the linter calls out that the event object doesn't actually satisfyAwsSdkCall
.#29845 removed the dependency
@aws-cdk/custom-resource-handlers
had onaws-sdk
. We should add this as devDependency since we're usingaws-sdk
in v2 handler mocks.Description of changes
I added
logApiResponseData
property to the event objects being tested to make the event satisfyAwsSdkCall
. I addedaws-sdk
as a dev dependency. We will remove this as part of the v2 handler removal.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license