Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-event-notifications): bug fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications #29019

Closed
wants to merge 1 commit into from

Conversation

sarangarav
Copy link
Contributor

@sarangarav sarangarav commented Feb 7, 2024

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested the changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 7, 2024 18:40
@sarangarav sarangarav changed the title Bug fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications fix(s3-event-notifications): bug fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications Feb 7, 2024
sarangarav added a commit to sarangarav/aws-cdk that referenced this pull request Feb 7, 2024
…tions and adding new event notifications on top of existing notifications aws#29019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 87b1ebc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sarangarav
Copy link
Contributor Author

Duplicate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants