Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): attach EBS volume to ECS task #28682

Closed
wants to merge 11 commits into from
Closed

feat(ecs): attach EBS volume to ECS task #28682

wants to merge 11 commits into from

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jan 12, 2024 •
edited
Loading

WIP.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2024 08:51
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Jan 12, 2024
@go-to-k go-to-k changed the title feat(ecs): attach EBS to ECS feat(ecs): attach EBS to ECS task Jan 12, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k go-to-k changed the title feat(ecs): attach EBS to ECS task feat(ecs): attach EBS volume to ECS task Jan 12, 2024
@go-to-k
feat(ecs): attach EBS to ECS
041868c 
change to volumeName

doc

renderVolumeConfigurations

propagateTags

task definition
@go-to-k go-to-k force-pushed the attach-ebs-to-ecs branch 3 times, most recently from 6da2a58 to b24ce8e Compare January 12, 2024 11:33
@go-to-k
validations and VolumeType default
7ad0431 
change validations

change validation

validations
@mrgrain
Copy link
Contributor

mrgrain commented Jan 12, 2024

@go-to-k It's now available: #28684

@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 12, 2024

@mrgrain

Thanks, I will take this PR.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 12, 2024 16:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k marked this pull request as ready for review January 12, 2024 16:31
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e6155d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2024
@MrArnoldPalmer
Copy link
Contributor

MrArnoldPalmer commented Jan 12, 2024 •
edited
Loading

@go-to-k we have another PR that we have been working on #28691

Let us know what you think!

@MrArnoldPalmer MrArnoldPalmer mentioned this pull request Jan 12, 2024
Merged
@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 12, 2024

@MrArnoldPalmer

Is that the intention of the core team? If so, I will withdraw my PR.

@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 12, 2024

@MrArnoldPalmer

Instead, I would like to support you by doing a community review of your PR.

@MrArnoldPalmer
Copy link
Contributor

@go-to-k yes, this PR has been worked on by the core team. We would appreciate a review!

@go-to-k go-to-k closed this Jan 12, 2024
@go-to-k go-to-k deleted the attach-ebs-to-ecs branch January 12, 2024 17:21
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@go-to-k @mrgrain @aws-cdk-automation @MrArnoldPalmer