feat(scheduler): flexible time windows #28098

sakurai-ryo · 2023-11-22T04:48:14Z

This PR adds support for configuring flexible time windows.

Description

Currently, users cannot configure the flexibleTimeWindow feature in the Scheduler construct.
This feature enhances flexibility and reliability, allowing tasks to be invoked within a defined time window.
https://docs.aws.amazon.com/scheduler/latest/UserGuide/managing-schedule-flexible-time-windows.html

CloudFormation allows users to take advantage of this feature as follows.
With this template, it will invokes the target within 10 minutes after the scheduled time.

Resources:
  Schedule:
    Type: AWS::Scheduler::Schedule
    Properties: 
      FlexibleTimeWindow: 
        Mode: "FLEXIBLE" # or "OFF"
        MaximumWindowInMinutes: 10 # between 1 and 1440
      Name: "sample-schedule"
      ScheduleExpression: "cron(0 9 * * ? *)"
      State: "ENABLED"
      Target:
        Arn: hoge
        RoleArn: hoge

Changes

add Enum indicating flexible time window mode

Currently there are only two modes, FLEXIBLE and OFF, so there is no problem using boolean instead of enum.
But I think it's better to use Enum to prepare for future expansion.
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-scheduler-schedule-flexibletimewindow.html

add property to `ScheduleProps` interface

flexibleTimeWindowMode property defaults to OFF to avoid a breaking change.

interface ScheduleProps {
  // ....
  /**
   * Determines whether the schedule is invoked within a flexible time window.
   *
   * @see https://docs.aws.amazon.com/scheduler/latest/UserGuide/managing-schedule-flexible-time-windows.html
   *
   * @default - FlexibleTimeWindowMode.OFF
   */
  readonly flexibleTimeWindowMode?: FlexibleTimeWindowMode;

  /**
   * The maximum time window during which the schedule can be invoked.
   *
   * @default - Required if flexibleTimeWindowMode is FLEXIBLE.
   */
  readonly maximumWindowInMinutes?: Duration;
}

set the added property to `CfnSchedule` construct

Basically, just set the values as documented, but with the following validations.

If flexibleTimeWindowMode is FLEXIBLE
- maximumWindowInMinutes must be specified
- maximumWindowInMinutes must be set from 1 to 1440 minutes

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-scheduler-schedule-flexibletimewindow.html

In addition, I added some unit tests and integ-tests.

others

fixed typo in README
- customizeable => customizable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…feat-scheduler-flex-window

go-to-k

Thanks for this PR!

I would like to add a new interface for FlexibleTimeWindow, what do you think?

Even if there are more properties associated with FlexibleTimeWindow in the future, it might not be too complicated. It might also be simpler than validation by annotation (as it is now).

sakurai-ryo · 2023-11-22T10:32:53Z

@go-to-k
Thank you for your feedback!
Initially, I had implemented this by defining a new interface, but after reviewing the section outlined in the DESIGN_GUIDELINES, I decided to go with the current implementation (although the naming of the properties is somewhat confusing).
https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md#flat

I'm wondering if the addition of the new interface is in line with this guideline.

go-to-k · 2023-11-22T10:44:43Z

Thanks, I see. Certainly correct. Let's go with this.
Please wait a moment so I can look at the other parts.

go-to-k

I commented some points. Please feel free to ask me if you need anything.

go-to-k · 2023-11-22T11:28:11Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+  /**
+   * FlexibleTimeWindow is disabled.
+   */
+  OFF = 'OFF',
+  /**
+   * FlexibleTimeWindow is enabled.
+   */
+  FLEXIBLE = 'FLEXIBLE'


In the meantime, please put in a line break.

Suggested change

/**

* FlexibleTimeWindow is disabled.

*/

OFF = 'OFF',

/**

* FlexibleTimeWindow is enabled.

*/

FLEXIBLE = 'FLEXIBLE'

/**

* FlexibleTimeWindow is disabled.

*/

OFF = 'OFF',

/**

* FlexibleTimeWindow is enabled.

*/

FLEXIBLE = 'FLEXIBLE'

go-to-k · 2023-11-22T11:34:38Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+  /**
+   * The maximum time window during which the schedule can be invoked.
+   *
+   * @default - Required if flexibleTimeWindowMode is FLEXIBLE.
+   */
+  readonly maximumWindowInMinutes?: Duration;


maximumWindowInMinutes must be set from 1 to 1440 minutes

I think it's user friendly to mention a range of the value that can be specified in this doc.

go-to-k · 2023-11-22T11:59:45Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+    flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,
+  ): CfnSchedule.FlexibleTimeWindowProperty {
+    if (!flexibleTimeWindowMode || flexibleTimeWindowMode === FlexibleTimeWindowMode.OFF) {
+      if (maximumWindowInMinutes) {
+        Annotations.of(this).addWarningV2('@aws-cdk/aws-scheduler:maximumWindowInMinutesIgnored', 'maximumWindowInMinutes is ignored when flexibleTimeWindowMode is not FLEXIBLE');
+      }
+      return {
+        mode: 'OFF',
+      };
+    }
+
+    if (!maximumWindowInMinutes) {
+      throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');
+    }
+    if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {
+      throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);
+    }
+    return {
+      mode: 'FLEXIBLE',
+      maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),
+    };
+  }


In my opinion,

Since this is not a case of using deprecated properties, affecting core params for the construct, etc., I do not think it is a case that is harmful enough to the user to warn using annotations.

I think it would be more consistent to use enum.

Feel free to comment.

Suggested change

private renderFlexibleTimeWindow(

flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,

): CfnSchedule.FlexibleTimeWindowProperty {

if (!flexibleTimeWindowMode || flexibleTimeWindowMode === FlexibleTimeWindowMode.OFF) {

if (maximumWindowInMinutes) {

Annotations.of(this).addWarningV2('@aws-cdk/aws-scheduler:maximumWindowInMinutesIgnored', 'maximumWindowInMinutes is ignored when flexibleTimeWindowMode is not FLEXIBLE');

}

return {

mode: 'OFF',

};

}

if (!maximumWindowInMinutes) {

throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');

}

if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {

throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);

}

return {

mode: 'FLEXIBLE',

maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),

};

}

private renderFlexibleTimeWindow(

flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,

): CfnSchedule.FlexibleTimeWindowProperty {

if (!flexibleTimeWindowMode || flexibleTimeWindowMode === FlexibleTimeWindowMode.OFF) {

return {

mode: FlexibleTimeWindowMode.OFF,

};

}

if (!maximumWindowInMinutes) {

throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');

}

if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {

throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);

}

return {

mode: flexibleTimeWindowMode,

maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),

};

}

go-to-k · 2023-11-22T12:23:08Z

packages/@aws-cdk/aws-scheduler-alpha/test/schedule.test.ts

+    });
+
+    test('throw error when maximumWindowInMinutes is more than 1440', () => {


It is not big deal but...

Suggested change

test('throw error when maximumWindowInMinutes is more than 1440', () => {

test('throw error when maximumWindowInMinutes is greater than 1440', () => {

…feat-scheduler-flex-window

go-to-k · 2023-11-24T12:02:41Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+    flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,
+  ): CfnSchedule.FlexibleTimeWindowProperty {
+    if (!flexibleTimeWindowMode || flexibleTimeWindowMode === FlexibleTimeWindowMode.OFF) {
+      return {
+        mode: FlexibleTimeWindowMode.OFF,
+      };
+    }
+
+    if (!maximumWindowInMinutes) {
+      throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');
+    }
+    if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {
+      throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);
+    }
+    return {
+      mode: flexibleTimeWindowMode,
+      maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),
+    };
+  }


Thanks for the fix!

Sorry, this one might be better. Because this one has fewer branching conditions. (The actual quantity will not change, but...)

Suggested change

private renderFlexibleTimeWindow(

flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,

): CfnSchedule.FlexibleTimeWindowProperty {

if (!flexibleTimeWindowMode || flexibleTimeWindowMode === FlexibleTimeWindowMode.OFF) {

return {

mode: FlexibleTimeWindowMode.OFF,

};

}

if (!maximumWindowInMinutes) {

throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');

}

if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {

throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);

}

return {

mode: flexibleTimeWindowMode,

maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),

};

}

private renderFlexibleTimeWindow(

flexibleTimeWindowMode?: FlexibleTimeWindowMode, maximumWindowInMinutes?: Duration,

): CfnSchedule.FlexibleTimeWindowProperty {

const mode = flexibleTimeWindowMode ?? FlexibleTimeWindowMode.OFF;

if (mode === FlexibleTimeWindowMode.OFF) {

return {

mode,

};

}

if (!maximumWindowInMinutes) {

throw new Error('maximumWindowInMinutes must be provided when flexibleTimeWindowMode is set to FLEXIBLE');

}

if (maximumWindowInMinutes.toMinutes() < 1 || maximumWindowInMinutes.toMinutes() > 1440) {

throw new Error(`maximumWindowInMinutes must be between 1 and 1440, got ${maximumWindowInMinutes.toMinutes()}`);

}

return {

mode,

maximumWindowInMinutes: maximumWindowInMinutes.toMinutes(),

};

}

go-to-k

Thanks, looks good.

sakurai-ryo · 2023-11-24T13:05:48Z

@go-to-k
Thanks for the quick review!

scanlonp

Hey @sakurai-ryo, apologies we are getting around to this a little late. I think this case is a great opportunity for an Enum like class! For example

new scheduler.Schedule(stack, 'UseFlexibleTimeWindow', {
  schedule: expression,
  target: target,
  flexibleTimeWindow: scheduler.FlexibleTimeWindowMode.Flexible(cdk.Duration.minutes(10)),
});

and

new scheduler.Schedule(stack, 'UseFlexibleTimeWindow', {
  schedule: expression,
  target: target,
  flexibleTimeWindow: scheduler.FlexibleTimeWindowMode.Off(),
});

This will tightly couple the mode to the properties it needs! I think this will give the best user experience and be extensible.

You can certainly improve my naming as well!

…feat-scheduler-flex-window

Pull request has been modified.

sakurai-ryo · 2023-12-08T14:04:47Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+  /**
+   * FlexibleTimeWindow is disabled.
+   */
+  public static off(): FlexibleTimeWindowMode {


I changed it to camelCase because it resulted in an error during cdk-build.

error JSII8002: Method and property (unless they are static readonly) names must use camelCase. Rename "@aws-cdk/aws-scheduler-alpha.FlexibleTimeWindowMode.Flexible" to "flexible" error JSII8002: Method and property (unless they are static readonly) names must use camelCase. Rename "@aws-cdk/aws-scheduler-alpha.FlexibleTimeWindowMode.Off" to "off"

sakurai-ryo · 2023-12-08T14:09:37Z

@scanlonp
No problem at all! Thank you for the review!
I've made the changes. Please review them again.

kaizencc

Hi @sakurai-ryo, I have some naming convention nits here. But otherwise looks good

kaizencc · 2023-12-12T19:36:37Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+   *
+   * Must be between 1 to 1440 minutes.
+   *
+   * @default - Required if mode is FLEXIBLE.


This isn't the correct use of the @default tag. Should describe the default if mode is not flexible

kaizencc · 2023-12-12T19:37:27Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+  /**
+   * Determines whether the schedule is invoked within a flexible time window.
+   */
+  public readonly mode: string;


Suggested change

public readonly mode: string;

public readonly mode: 'OFF' | 'FLEXIBLE';

kaizencc · 2023-12-12T19:39:36Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+  /**
+   * FlexibleTimeWindow is enabled.
+   */
+  public static flexible(maximumWindowInMinutes: Duration): FlexibleTimeWindowMode {


Suggested change

public static flexible(maximumWindowInMinutes: Duration): FlexibleTimeWindowMode {

public static flexible(maxWindow: Duration): FlexibleTimeWindowMode {

It doesn't need to be in minutes anymore cuz we're supplying a Duration

kaizencc · 2023-12-12T19:39:57Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+/**
+ * A time window during which EventBridge Scheduler invokes the schedule.
+ */
+export class FlexibleTimeWindowMode {


Suggested change

export class FlexibleTimeWindowMode {

export class TimeWindow {

Will be nicer to write TimeWindow.flexible()

kaizencc · 2023-12-12T19:40:55Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+   *
+   * @default - Required if mode is FLEXIBLE.
+   */
+  public readonly maximumWindowInMinutes?: Duration;


Suggested change

public readonly maximumWindowInMinutes?: Duration;

public readonly maxWindow?: Duration;

kaizencc · 2023-12-12T19:41:20Z

packages/@aws-cdk/aws-scheduler-alpha/lib/schedule.ts

+   *
+   * @default FlexibleTimeWindowMode.off()
+   */
+  readonly flexibleTimeWindow?: FlexibleTimeWindowMode;


Suggested change

readonly flexibleTimeWindow?: FlexibleTimeWindowMode;

readonly timeWindow?: TimeWindow;

…feat-scheduler-flex-window

Pull request has been modified.

sakurai-ryo · 2023-12-13T13:55:28Z

@kaizencc
Thanks! I fixed them.

kaizencc

Oh shoot! Merge conflicts with your other PR that got merged :). Do you mind fixing those conflicts @sakurai-ryo? Everything else looks good.

…feat-scheduler-flex-window

Pull request has been modified.

sakurai-ryo · 2023-12-14T02:44:16Z

@kaizencc
fixed those conflicts 👍

aws-cdk-automation · 2023-12-15T12:48:38Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: fb820e9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-12-15T12:49:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

sakurai-ryo added 2 commits November 22, 2023 00:29

feat(scheduler): add support for flexible time window

ff675c0

feat(scheduler): add warning

85b60d4

github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Nov 22, 2023

aws-cdk-automation requested a review from a team November 22, 2023 04:48

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

5f3496b

…feat-scheduler-flex-window

sakurai-ryo changed the title ~~feat(scheduler): add support for configuring flexible time windows~~ feat(scheduler): add support for flexible time windows Nov 22, 2023

feat(scheduler): fix build failed

b71fd8e

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2023

go-to-k suggested changes Nov 22, 2023

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2023

go-to-k suggested changes Nov 22, 2023

View reviewed changes

sakurai-ryo added 3 commits November 24, 2023 17:24

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

70362d5

…feat-scheduler-flex-window

feat(scheduler): fixed for the review

21c4331

feat(scheduler): fix build

2a2b00d

go-to-k suggested changes Nov 24, 2023

View reviewed changes

feat(scheduler): fix for the review

24cebc1

go-to-k approved these changes Nov 24, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 24, 2023

github-actions bot mentioned this pull request Dec 1, 2023

Monthly PR metrics report - November 2023 #28212

Closed

scanlonp previously requested changes Dec 5, 2023

View reviewed changes

scanlonp self-assigned this Dec 5, 2023

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 5, 2023

sakurai-ryo added 3 commits December 6, 2023 12:00

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

e2ce811

…feat-scheduler-flex-window

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

8fc8d33

…feat-scheduler-flex-window

feat(scheduler): refactor class

443fa09

sakurai-ryo added 4 commits December 8, 2023 21:38

feat(scheduler): fix build

9af2ec8

feat(code): delete new line

a8c279a

feat(scheduler): change property names

ba4630b

feat(scheduler): fix build

540561c

sakurai-ryo commented Dec 8, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 8, 2023

kaizencc previously requested changes Dec 12, 2023

View reviewed changes

kaizencc changed the title ~~feat(scheduler): add support for flexible time windows~~ feat(scheduler): flexible time windows Dec 12, 2023

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 12, 2023

sakurai-ryo added 2 commits December 13, 2023 17:30

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

8169a6d

…feat-scheduler-flex-window

feat(scheduler): fix for the review

f509ef6

feat(scheduler): fix tests

461f5ba

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 13, 2023

kaizencc previously requested changes Dec 13, 2023

View reviewed changes

Merge branch 'master' of https://github.com/sakurai-ryo/aws-cdk into …

e990c2a

…feat-scheduler-flex-window

Merge branch 'main' into feat-scheduler-flex-window

fb820e9

kaizencc approved these changes Dec 15, 2023

View reviewed changes

mergify bot merged commit 6554e48 into aws:main Dec 15, 2023
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scheduler): flexible time windows #28098

feat(scheduler): flexible time windows #28098

sakurai-ryo commented Nov 22, 2023 •

edited

Loading

go-to-k left a comment •

edited

Loading

sakurai-ryo commented Nov 22, 2023

go-to-k commented Nov 22, 2023

go-to-k left a comment

go-to-k Nov 22, 2023

go-to-k Nov 22, 2023

go-to-k Nov 22, 2023 •

edited

Loading

go-to-k Nov 22, 2023

go-to-k Nov 24, 2023 •

edited

Loading

go-to-k left a comment

sakurai-ryo commented Nov 24, 2023

scanlonp left a comment

sakurai-ryo Dec 8, 2023 •

edited

Loading

sakurai-ryo commented Dec 8, 2023

kaizencc left a comment

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

kaizencc Dec 12, 2023

sakurai-ryo commented Dec 13, 2023

kaizencc left a comment

sakurai-ryo commented Dec 14, 2023

aws-cdk-automation commented Dec 15, 2023

mergify bot commented Dec 15, 2023

		});

		test('throw error when maximumWindowInMinutes is more than 1440', () => {

	public readonly mode: string;
	public readonly mode: 'OFF' \| 'FLEXIBLE';

	public static flexible(maximumWindowInMinutes: Duration): FlexibleTimeWindowMode {
	public static flexible(maxWindow: Duration): FlexibleTimeWindowMode {

	export class FlexibleTimeWindowMode {
	export class TimeWindow {

	public readonly maximumWindowInMinutes?: Duration;
	public readonly maxWindow?: Duration;

	readonly flexibleTimeWindow?: FlexibleTimeWindowMode;
	readonly timeWindow?: TimeWindow;

feat(scheduler): flexible time windows #28098

feat(scheduler): flexible time windows #28098

Conversation

sakurai-ryo commented Nov 22, 2023 • edited Loading

Description

Changes

add Enum indicating flexible time window mode

add property to ScheduleProps interface

set the added property to CfnSchedule construct

others

go-to-k left a comment • edited Loading

Choose a reason for hiding this comment

sakurai-ryo commented Nov 22, 2023

go-to-k commented Nov 22, 2023

go-to-k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

go-to-k Nov 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

go-to-k Nov 24, 2023 • edited Loading

Choose a reason for hiding this comment

go-to-k left a comment

Choose a reason for hiding this comment

sakurai-ryo commented Nov 24, 2023

scanlonp left a comment

Choose a reason for hiding this comment

sakurai-ryo Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

sakurai-ryo commented Dec 8, 2023

kaizencc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sakurai-ryo commented Dec 13, 2023

kaizencc left a comment

Choose a reason for hiding this comment

sakurai-ryo commented Dec 14, 2023

aws-cdk-automation commented Dec 15, 2023

AWS CodeBuild CI Report

mergify bot commented Dec 15, 2023

sakurai-ryo commented Nov 22, 2023 •

edited

Loading

add property to `ScheduleProps` interface

set the added property to `CfnSchedule` construct

go-to-k left a comment •

edited

Loading

go-to-k Nov 22, 2023 •

edited

Loading

go-to-k Nov 24, 2023 •

edited

Loading

sakurai-ryo Dec 8, 2023 •

edited

Loading