Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): support for Kubernetes version 1.28 #27930

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Nov 10, 2023

Similar to #25897, this PR adds eks with k8s 1.28 support.

Closes #27500

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 10, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2023 15:40
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 10, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud
Copy link
Contributor Author

pahud commented Nov 10, 2023

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 10, 2023
@@ -489,7 +489,7 @@
},
"jsiiRosetta": {
"exampleDependencies": {
"@aws-cdk/lambda-layer-kubectl-v27": "^2.0.0",
"@aws-cdk/lambda-layer-kubectl-v28": "^2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I should modify this but this avoids the build failure.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 10, 2023
@scanlonp scanlonp added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Nov 10, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 10, 2023 18:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 10, 2023
Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 19fb721
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0b1f818 into aws:main Nov 10, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
Similar to #25897, this PR adds eks with k8s 1.28 support.

Closes #27500 

<img width="792" alt="image" src="https://github.com/aws/aws-cdk/assets/278432/9cfec3f1-360d-4e7c-95fe-9a5177847f1d">


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Feb 9, 2024
Similar to #27930, this PR adds eks with k8s 1.29 support.

Addresses #28872 thread. Closes #28983.

### **!! Depends on cdklabs/awscdk-asset-kubectl#546 being merged in first. !!**

/cc @kaizencc @pahud 

### Reason for this change

K8s 1.29 on EKS has been released on 1/23/2024.  See: https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-29/

### Description of changes

Added support for eks 1.29.

### Description of how you validated changes

Deployed an EKS cluster with k8s 1.29.

![image](https://github.com/aws/aws-cdk/assets/31543/ba770020-2087-498a-a1eb-3e890df05062)

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
Similar to #27930, this PR adds eks with k8s 1.29 support.

Addresses #28872 thread. Closes #28983.

### **!! Depends on cdklabs/awscdk-asset-kubectl#546 being merged in first. !!**

/cc @kaizencc @pahud 

### Reason for this change

K8s 1.29 on EKS has been released on 1/23/2024.  See: https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-29/

### Description of changes

Added support for eks 1.29.

### Description of how you validated changes

Deployed an EKS cluster with k8s 1.29.

![image](https://github.com/aws/aws-cdk/assets/31543/ba770020-2087-498a-a1eb-3e890df05062)

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(KubernetesVersion): (Add support for Kubernetes version 1.28)
3 participants