Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduler-targets): CodeBuild scheduler target #27792

Merged
merged 11 commits into from
Nov 2, 2023
Merged

feat(scheduler-targets): CodeBuild scheduler target #27792

merged 11 commits into from
Nov 2, 2023

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Nov 1, 2023

Closes #27448.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 1, 2023 12:23
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 1, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@daschaa daschaa changed the title (aws-scheduler-targets-alpha): add CodeBuild as target for scheduler feat(aws-scheduler-targets-alpha): add CodeBuild as target for scheduler Nov 1, 2023
@daschaa daschaa changed the title feat(aws-scheduler-targets-alpha): add CodeBuild as target for scheduler feat(scheduler-targets-alpha): add CodeBuild as target for scheduler Nov 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 1, 2023 19:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@daschaa daschaa marked this pull request as ready for review November 1, 2023 19:30
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 1, 2023
lpizzinidev
lpizzinidev suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor adjustments to be made.

packages/@aws-cdk/aws-scheduler-targets-alpha/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-scheduler-targets-alpha/test/codebuild-start-build.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-scheduler-targets-alpha/test/codebuild-start-build.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-scheduler-targets-alpha/test/codebuild-start-build.test.ts Outdated Show resolved Hide resolved
@daschaa
Copy link
Contributor Author

daschaa commented Nov 2, 2023

@lpizzinidev Thanks for the review! 🥳 I've implemented the suggested changes.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2023
kaizencc
kaizencc previously requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @daschaa. Minor comment

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/codebuild-start-build.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-scheduler-targets-alpha/README.md Outdated Show resolved Hide resolved
@lpizzinidev
Copy link
Contributor

@daschaa
Also, the module in the title should not contain alpha: feat(scheduler-targets) ...

@mergify mergify bot dismissed kaizencc’s stale review November 2, 2023 16:01

Pull request has been modified.

@daschaa daschaa changed the title feat(scheduler-targets-alpha): add CodeBuild as target for scheduler feat(scheduler-targets): add CodeBuild as target for scheduler Nov 2, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 2, 2023
kaizencc
kaizencc approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daschaa! Thanks for the reviews @lpizzinidev!

@kaizencc kaizencc changed the title feat(scheduler-targets): add CodeBuild as target for scheduler feat(scheduler-targets): CodeBuild scheduler target Nov 2, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 2, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 01d20f2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9d63316 into aws:main Nov 2, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-scheduler-targets-alpha): Add CodeBuildStartBuild Target
4 participants
@daschaa @lpizzinidev @aws-cdk-automation @kaizencc