Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): add support for subscription filter policy #2778

Merged
merged 16 commits into from
Jun 21, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jun 6, 2019

Add a new filterPolicy prop to all SNS subscriptions (aws-sns-subscriptions).

The filter policy can be defined using the new SubscriptionFilterPolicy class.

Moved the creation of the Subscription back to aws-sns to avoid code repetitions.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@jogold jogold requested a review from a team as a code owner June 6, 2019 21:11
@jogold
Copy link
Contributor Author

jogold commented Jun 10, 2019

Seen #2804, will adapt when merged

@jogold jogold requested a review from SoManyHs as a code owner June 14, 2019 08:26
@jogold
Copy link
Contributor Author

jogold commented Jun 14, 2019

@rix0rrr see updated README for new "interface/api".

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

packages/@aws-cdk/aws-sns/lib/subscription.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-sns/lib/subscriber.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants