Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): cdk destroy does not throw error for a non-existent stack #27293

Closed
wants to merge 10 commits into from

Merge branch 'main' into fix/destroy-not-exits

b16eb1f
Select commit
Loading
Failed to load commit list.
Closed

fix(cli): cdk destroy does not throw error for a non-existent stack #27293

Merge branch 'main' into fix/destroy-not-exits
b16eb1f
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Nov 16, 2023 in 1s

8 potential rules

Rule: automatic merge (queue)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • status-success=validate-pr
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • -approved-reviews-by~=author
  • -closed
  • -draft [:pushpin: queue requirement]
  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • -merged
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (comment)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • status-success=validate-pr
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • -merged
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (2+ approvers) (queue)

  • #approved-reviews-by>=2
  • #changes-requested-reviews-by=0
  • label~=two-approvers
  • status-success=validate-pr
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • -approved-reviews-by~=author
  • -closed
  • -draft [:pushpin: queue requirement]
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (2+ approvers) (comment)

  • #approved-reviews-by>=2
  • #changes-requested-reviews-by=0
  • label~=two-approvers
  • status-success=validate-pr
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base!=release
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (no-squash) (queue)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • label~=no-squash
  • status-success=validate-pr
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • -approved-reviews-by~=author
  • -closed
  • -draft [:pushpin: queue requirement]
  • -label~=(blocked|do-not-merge)
  • -merged
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge (no-squash) (comment)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • label~=no-squash
  • status-success=validate-pr
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge)
  • -merged
  • -title~=(WIP|wip)
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • status-success~=AWS CodeBuild us-east-1

Rule: remove stale reviews (dismiss_reviews)

  • changes-requested-reviews-by!=aws-cdk-automation
  • -closed
  • -merged
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base=main
  • label!=contribution/core

Rule: if fails conventional commits (comment)

  • status-failure=Semantic Pull Request
  • -closed
  • -merged
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]

💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!


3 not applicable rules

Rule: label core (label)

  • author~=^(rix0rrr|MrArnoldPalmer|iliapolo|otaviomacedo|madeline-k|kaizencc|comcalvi|corymhall|peterwoodworth|TheRealAmazonKendra|vinayak-kukreja|mrgrain|pahud|cgarvis|kellertk|HBobertz|sumupitchayan|SankyRed|udaypant|colifran|scanlonp|mikewrighton|moelasmar)$
  • -label~="contribution/core"

Rule: automatic merge of Dependabot PRs (queue)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • author~=dependabot
  • status-success=validate-pr
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
        • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • -closed
  • -draft [:pushpin: queue requirement]
  • -label~=(blocked|do-not-merge)
  • -merged
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
  • -title~=(WIP|wip)
  • status-success~=AWS CodeBuild us-east-1

Rule: automatic merge of Dependabot PRs (comment)

  • #approved-reviews-by>=1
  • #changes-requested-reviews-by=0
  • author~=dependabot
  • status-success=validate-pr
  • -closed
  • -label~=(blocked|do-not-merge)
  • -merged
  • -title~=(WIP|wip)
  • status-success~=AWS CodeBuild us-east-1
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com