chore: update area labels to match repository restructure #27232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
rix0rrr
reviewed
Sep 21, 2023
| @@ -63,224 +63,226 @@ env: | |||
|
|
|||
| AREA_AFFIXES: > | |||
| { | |||
| "prefixes":["@aws-cdk/"] | |||
| "prefixes":["@aws-cdk/", "aws-cdk-lib/", "aws-cdk-lib."] | |||
There was a problem hiding this comment.
Suggested change
| "prefixes":["@aws-cdk/", "aws-cdk-lib/", "aws-cdk-lib."] | |
| "prefixes":["@aws-cdk/", "aws-cdk-lib/", "aws-cdk-lib."] |
Can we turn 'em in to module/xxx or service/xxx ?
|
I like the relative path much more than service or module. Module is better than service since not all of the packages are services in and of themselves. Module provides little to no additional value. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Closing cuz it will take some additional work to get this up to snuff, and no one is available to do that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: This is something I would like to do in the future. However, possible dependencies on our current labels (metrics, actions, etc) makes this something that does not need to be done at the moment.
All of our "area" labels currently are prefixed with
@aws-cdk. Since the repository was restructured to have stable modules live inaws-cdk-liband alpha modules live in@aws-cdk, our labels should reflect that.Additionally, updated several labels for modules that have been graduated from alpha to stable.
Dependent on #27231 and
@aws-cdk/aws-kinesis-firehose-destinations-alpha,@aws-cdk/aws-scheduler-alpha, and@aws-cdk/aws-scheduler-targets-alphaneed to be created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license