Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sns-subscriptions): cannot add SqsSubscription when using an Sqs Construct from a different Constructs library #27227

Merged
merged 3 commits into from
Oct 5, 2023

Merge branch 'main' into fix/fix-is-construct-check

6f567e3
Select commit
Loading
Failed to load commit list.
Merged

fix(sns-subscriptions): cannot add SqsSubscription when using an Sqs Construct from a different Constructs library #27227

Merge branch 'main' into fix/fix-is-construct-check
6f567e3
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Oct 5, 2023 in 0s

The pull request embarked with main (c68ea44) is mergeable

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • status-success~=AWS CodeBuild us-east-1
  • all of [📃 From pull request rule automatic merge]:
    • #approved-reviews-by>=1
    • #changes-requested-reviews-by=0
    • -approved-reviews-by~=author
    • -closed
    • -draft [:pushpin: queue requirement]
    • -label~=(blocked|do-not-merge|no-squash|two-approvers)
    • -merged
    • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
    • -title~=(WIP|wip)
    • author!=dependabot-preview[bot]
    • author!=dependabot[bot]
    • base!=release
    • status-success=validate-pr
    • status-success~=AWS CodeBuild us-east-1
    • any of [:twisted_rightwards_arrows: queue conditions]:
      • all of [:pushpin: queue conditions of queue default]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • any of [🛡 GitHub branch protection]:
          • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
          • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
          • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-success=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-neutral=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped=AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)

Check-runs and statuses of the embarked pull request #27227:

auto-approvedetails
submit-to-test-pipelinedetails
AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)Build succeeded for project AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQvdetails
cli-changesdetails
download-if-workflow-rundetails
uploaddetails
uploaddetails
validate-prdetails