Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): make instanceType optional on multinode jobs #27223

Merged
merged 21 commits into from
Sep 26, 2023

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Sep 20, 2023

Make instanceType optional. It used to be required. It will default to a batch optimal instance type.

The breaking change is for MultiNodeJobDefinition.instanceType, which is now optional. This is not truly breaking because everyone has this property explicitly set now, and will continue to have it set after this change.

Closes #27185.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Sep 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 20, 2023 15:25
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 20, 2023
@comcalvi comcalvi marked this pull request as ready for review September 20, 2023 15:37
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 20, 2023
@TheRealAmazonKendra
Copy link
Contributor

Weird that setting something to optional is considered a breaking change.

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 21, 2023

On the question of making properties optional, this comes up way too often, so I made an explainer for it:

https://github.com/aws/jsii/pull/4274/files?short_path=f5d91d1#diff-f5d91d104bff5f6eba3495d9aa4ef6d0e2854a010d6c2754acdd98536afc3c05

@comcalvi
Copy link
Contributor Author

comcalvi commented Sep 26, 2023

thanks for writeup @rix0rrr, that's helpful

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 26, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 69b2059
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6616026 into main Sep 26, 2023
16 of 17 checks passed
@mergify mergify bot deleted the comcalvi/optional-instance-type-for-multinode-jobs-batch branch September 26, 2023 20:54
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-batch: MultiNodeJobDefinition Incorrectly Requires InstanceType
4 participants