Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom_resources): Provider Lambda function is missing lambda:GetFunctionConfiguration permission #27204

Closed
wants to merge 10 commits into from

Conversation

jasoncaoawshc
Copy link

This PR solves the problem of missing permissions for lambda created with the provider framework.

We found this issue in the landing zone accelerator solution that leverages the custom_resources module. Related issue.

Closes #26838.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Sep 19, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2023 19:22
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 19, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jasoncaoawshc
Copy link
Author

Exemption Request: integration tests do not exist for the custom_resources module

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 19, 2023
@scanlonp
Copy link
Contributor

scanlonp commented Oct 4, 2023

Hello, the custom resource integ tests live here https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test.

Additionally, we will not be able to provide a meaningful review until the build is passing.

@vinayak-kukreja
Copy link
Contributor

vinayak-kukreja commented Oct 10, 2023

Hey, I see you have opened the PR from main branch on your fork. Could you move to another branch. You can find more information about this in our Contribution guide.

@vinayak-kukreja vinayak-kukreja removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 10, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@jasoncaoawshc
Copy link
Author

Exemption request: We can't really integ test this as it would require a lambda function that was already inactive (20 minute wait time) and we don't have that resource setup.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 11, 2023
@vinayak-kukreja
Copy link
Contributor

Exemption request: We can't really integ test this as it would require a lambda function that was already inactive (20 minute wait time) and we don't have that resource setup.

That is fine, we can run the test for you. But the build is failing right now and we cannot prioritize a review for this PR till that is fixed. Let us know if we can assist with anything.

@vinayak-kukreja vinayak-kukreja removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 11, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 12, 2023 18:22

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 50ed7b2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom_resources: Provider Lambda function is missing lambda:GetFunctionConfiguration
4 participants