Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "chore(ecs): clarify it's possible to use image digest on fromEcrRepository" #27143

Merged
merged 1 commit into from
Sep 14, 2023
Merged

revert: "chore(ecs): clarify it's possible to use image digest on fromEcrRepository" #27143

merged 1 commit into from
Sep 14, 2023

Conversation

sumupitchayan
Copy link
Contributor

@sumupitchayan sumupitchayan commented Sep 14, 2023 •
edited by kaizencc
Loading

Reverts #27115

Renaming tag prop to tagOrDigest of the ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.

@github-actions github-actions bot added the p2 label Sep 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 14, 2023 14:45
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 14, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sumupitchayan sumupitchayan changed the title Revert "chore(ecs): clarify it's possible to use image digest on fromEcrRepository" revert: "chore(ecs): clarify it's possible to use image digest on fromEcrRepository" Sep 14, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 14, 2023 14:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d4916d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f0d416e into main Sep 14, 2023
33 of 34 checks passed
@mergify mergify bot deleted the revert-27115-feat/ecr_image_digest branch September 14, 2023 15:09
@colifran colifran mentioned this pull request Sep 14, 2023
Closed
sumupitchayan added a commit that referenced this pull request Sep 14, 2023
@sumupitchayan
revert: "chore(ecs): clarify it's possible to use image digest on fro…
049153e 
…mEcrRepository" (#27143)

Reverts #27115

Renaming `tag` prop to `tagOrDigest` of the `ContainerImage.fromEcrRepository` function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
@sumupitchayan
revert: "chore(ecs): clarify it's possible to use image digest on fro…
136c379 
…mEcrRepository" (#27143)

Reverts #27115

Renaming `tag` prop to `tagOrDigest` of the `ContainerImage.fromEcrRepository` function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumupitchayan @aws-cdk-automation @kaizencc