Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-resources): empty Lambda response payload causes deployment failure #27000

Merged
merged 8 commits into from
Sep 6, 2023
Merged

fix(custom-resources): empty Lambda response payload causes deployment failure #27000

merged 8 commits into from
Sep 6, 2023

Commits on Sep 4, 2023

  1. fix(custom-resources): empty response causes deployment failure 

    The payload response of a Lambda used to be a `string`, and could
occasionally be `""`, which we detected and special-case parsed to
an empty object.

In SDKv3, the payload response of a Lambda changed to type `Uint8Array`,
but a `Uint8Array(0)` doesn't check as *falsey*, so we'd decode it to
`""` and then the `JSON.parse()` of that would fail.

First decode, then check the string for emptyness.

Fixes #26429.
    @rix0rrr
    rix0rrr committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    c0c45a7 View commit details
    Browse the repository at this point in the history

  2. Other location as well

    @rix0rrr
    rix0rrr committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    db81fcd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Add unit test

    @rix0rrr
    rix0rrr committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e6d0493 View commit details
    Browse the repository at this point in the history

  2. Snapshots

    @rix0rrr
    rix0rrr committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    98232b5 View commit details
    Browse the repository at this point in the history

  3. More snapshot update

    @rix0rrr
    rix0rrr committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7aede7e View commit details
    Browse the repository at this point in the history

  4. Snapshot updates

    @rix0rrr
    rix0rrr committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    cd4edb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Revert change to assertions

    @rix0rrr
    rix0rrr committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8504b08 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into huijbers/payload-parse

    @rix0rrr
    rix0rrr committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    cf7524e View commit details
    Browse the repository at this point in the history