Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(region-info): sort tables and remove region name comments #26831

Merged
merged 2 commits into from
Aug 24, 2023
Merged

chore(region-info): sort tables and remove region name comments #26831

merged 2 commits into from
Aug 24, 2023

Conversation

SankyRed
Copy link
Contributor

@SankyRed SankyRed commented Aug 21, 2023 •
edited
Loading

Code Changes:

  • Refactoring the fact-tables.ts file to make the entire file to be set alphabetically.
  • Helps while adding new region, looking up values for already set regions and avoid duplication.

Closes #26826.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 21, 2023 20:33
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Aug 21, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 21, 2023
@SankyRed SankyRed linked an issue Aug 21, 2023 that may be closed by this pull request
Refactoring the facts table #26809
Closed
2 tasks
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 21, 2023
rix0rrr
rix0rrr requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain to me what changed and why, and why it's now more "consistent" ?

packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 22, 2023
@SankyRed SankyRed force-pushed the SankyRed/Refactor-fact-tables branch 4 times, most recently from 0d78e41 to ff7fcd4 Compare August 22, 2023 18:13
@SankyRed SankyRed force-pushed the SankyRed/Refactor-fact-tables branch from ff7fcd4 to d3bd988 Compare August 23, 2023 03:03
@SankyRed SankyRed force-pushed the SankyRed/Refactor-fact-tables branch 2 times, most recently from 89f44a3 to 6cf7dc6 Compare August 23, 2023 14:06
@SankyRed SankyRed requested a review from rix0rrr August 23, 2023 14:38
@SankyRed SankyRed force-pushed the SankyRed/Refactor-fact-tables branch from 6cf7dc6 to b8f448a Compare August 23, 2023 16:07
@SankyRed SankyRed force-pushed the SankyRed/Refactor-fact-tables branch from b8f448a to b1cacfc Compare August 24, 2023 13:33
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 79a8a7b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SankyRed SankyRed requested a review from rix0rrr August 24, 2023 14:14
@rix0rrr rix0rrr changed the title chore(region-info): Refactoring the fact tables file to be consistent chore(region-info): sort tables and remove region name comments Aug 24, 2023
@SankyRed SankyRed self-assigned this Aug 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6fb1207 into main Aug 24, 2023
15 checks passed
@mergify mergify bot deleted the SankyRed/Refactor-fact-tables branch August 24, 2023 14:18
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@mrgrain mrgrain Awaiting requested review from mrgrain

Assignees

@SankyRed SankyRed

Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring the facts table
4 participants
@SankyRed @aws-cdk-automation @mrgrain @rix0rrr