-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect #26326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
I am from the Windows Containers Technologies team who owns the updating the public SSM param for Windows optimized AMIs. We have a customer who would like to get these params updated so they may be used in CDK. Can I get an Exemption Request from the integ tests? |
The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html) Closes aws#26327.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…aws#26326) The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html) ``` Current incorrect format: /aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id Correct format: /aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized ``` Closes aws#26327. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found here
Closes #26327.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license