Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect #26326

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

arun-annamalai
Copy link
Contributor

@arun-annamalai arun-annamalai commented Jul 11, 2023

The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found here

Current incorrect format:
/aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id
Correct format: 
/aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized

Closes #26327.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2023 23:09
@github-actions github-actions bot added the p2 label Jul 11, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@arun-annamalai
Copy link
Contributor Author

arun-annamalai commented Jul 11, 2023

I am from the Windows Containers Technologies team who owns the updating the public SSM param for Windows optimized AMIs. We have a customer who would like to get these params updated so they may be used in CDK. Can I get an Exemption Request from the integ tests?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 11, 2023
The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

Closes aws#26327.
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 12, 2023
@mrgrain mrgrain changed the title fix(ecs): Correct Windows ECS Optimized AMI SSM parameter fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect Jul 12, 2023
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jul 12, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 12, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 12, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 12, 2023 11:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 88c4ca1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 43013d0 into aws:main Jul 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
…aws#26326)

The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

```
Current incorrect format:
/aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id
Correct format: 
/aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized
```

Closes aws#26327.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): The current Windows ECS optimized ssm params format is incorrect
3 participants