Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty string as keyPrefixEquals #26316

Closed
wants to merge 5 commits into from

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 11, 2023

Closes #26242 .

Re-roll of #26243


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2023 10:40
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jul 11, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 11, 2023
@mrgrain mrgrain changed the title Mrgrain/fix/allow empty key prefix equals fix: allow empty string as keyPrefixEquals Jul 11, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1ae2d32
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain marked this pull request as draft July 11, 2023 19:06
@mrgrain mrgrain closed this Jul 16, 2023
@mrgrain mrgrain deleted the mrgrain/fix/allow-empty-keyPrefixEquals branch July 26, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3: websiteRoutingRule doesn't allow empty keyPrefixEquals
3 participants