-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigateway): update imported RestAPIs type to grant access to RestAPIBase methods #26254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Exemption Request. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Hey thanks for the PR, unfortunately we can't go forward with this PR like this. Here's why:
You are welcome to open a new PR with a different approach. As this is a |
fromRestApiId
andfromRestApiAttributes
were returning the imported RestAPI asIRestApi
, preventing methods implemented byRestAPIBase
from being called without type casting.This fix solves the problem by changing the return type of the two functions.
Closes #26247.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license